JIT: introduce filtering of modules with --arch and --platform arguments #43
Conversation
Signed-off-by: Paul Guyot <[email protected]>
| deduplicate([H | T]) -> | ||
| [H | [X || X <- deduplicate(T), X /= H]]. | ||
|
|
||
| filter_jit(Files0, undefined, generic_unix) -> |
There was a problem hiding this comment.
Whether or not we use emu as the default non jit arch I think we should also match undefined too and the third parameter should match to anything (for either undefined or emu), since the emulated code can be run on any platform and some user or even another application using the API might pass a different "platform" here, which should be allowed.
| application_module => undefined, | ||
| include_lines => true | ||
| include_lines => true, | ||
| arch => undefined, |
There was a problem hiding this comment.
I was going to make the arch parameter pass though all of the atomvm_rebar3_plugin tasks, so the default (non-jit) arch will be emu for the standard emulated VM. It will simplify integration if we use emu here as the default if no native arch target is supplied.
| parse_args(T, {Opts#{format => Format}, Args}); | ||
| parse_args(["--arch", Arch | T], {Opts, Args}) -> | ||
| parse_args(T, {Opts#{arch => list_to_atom(Arch)}, Args}); | ||
| parse_args(["--platform", Platform | T], {Opts, Args}) -> |
There was a problem hiding this comment.
We also need to add these parameters to the print_help() function in packbeam.erl.
2 participants
No description provided.